Skip to content

Update remove.rst #3924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Update remove.rst #3924

wants to merge 3 commits into from

Conversation

Ha99y
Copy link
Contributor

@Ha99y Ha99y commented Jun 10, 2014

Add note about removing web/bundles/acmedemo directory

Add note about removing web/bundles/acmedemo directory
@@ -73,6 +73,12 @@ should remove the bundle from the filesystem. The bundle is located in the
``src/Acme/DemoBundle`` directory. You should remove this directory and you
can remove the ``Acme`` directory as well.

3.1 Remove bundle resources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove Bundle Resources

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this new section should be moved below the tip box

~~~~~~~~~~~~~~~~~~~~~~~~~~~

Remove the Acme resource directory from the application's web folder. It can be found in ``web/bundles/acmedemo``.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can be even more direct. What do you guys think about:

Remove the web/bundles/acmedemo directory. This contains the public assets (e.g CSS) for the bundle.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also take care of the second goal of this article: talk about removing a bundle in general. So I would propose something along the lines of "Remove the assets of the bundle in the web/ directory (e.g. web/bundles/acmedemo)"

@weaverryan
Copy link
Member

Ping @Ha99y! What do you think about my suggestion? Do you have some time to make the change? Just let me know if you don't :).

Thanks!

@@ -81,6 +81,11 @@ can remove the ``Acme`` directory as well.

echo $this->container->get('kernel')->getBundle('AcmeDemoBundle')->getPath();

3.1 Remove Bundle Resources
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say "Assets" instead of "Resources"

@javiereguiluz
Copy link
Member

Hi @Ha99y, do you have some time to make the changes proposed by the doc reviewers? If not, please feel free to say it and we'll take care of this. Thank you!

@wouterj
Copy link
Member

wouterj commented Sep 16, 2014

Replaced by #4238

@wouterj wouterj closed this Sep 16, 2014
weaverryan added a commit that referenced this pull request Sep 19, 2014
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #4238).

Discussion
----------

Finished #3924

Commits
-------

6f5c67c Applied comments
d16e21e Update remove.rst
ec568da Update remove.rst
6e72acc Update remove.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants